fix: improve read support - #149
Merged
Merged
Conversation
The responseCodeChecker method now takes raw parameters and does more work: convert them and check the values The resulting code is easier to use Signed-off-by: Alexandre Bruyelles <git@jack.fr.eu.org>
ReadResponseCodes was never actually used Also, improve the situation when oldSanitized is null (aka: we just created the object) Signed-off-by: Alexandre Bruyelles <git@jack.fr.eu.org>
3 tasks
Restore sensitive-response helpers and the refactored responseCodeChecker after the main merge, and update curl_action to use the new checker signature. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Owner
|
Merged — thank you @JackSlateur for the read drift fixes and the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
As of v2.3.0, drifting is not working
v2.3.0 has the following issues:
This PR focus on the first two topics
The first commit is a small refactoring
The second implements read_requests_code and also fixes the second issue
The last bit remains to be fixed
Thank you for the review